mirror of
https://github.com/docker/login-action.git
synced 2026-07-29 21:22:01 +02:00
Compare commits
2 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| b8845202f0 | |||
| a611a01fe0 |
@@ -5,6 +5,7 @@ import {beforeEach, describe, expect, test, vi} from 'vitest';
|
|||||||
import * as dockerhub from '../src/dockerhub.js';
|
import * as dockerhub from '../src/dockerhub.js';
|
||||||
|
|
||||||
vi.mock('@actions/core', () => ({
|
vi.mock('@actions/core', () => ({
|
||||||
|
debug: vi.fn(),
|
||||||
getIDToken: vi.fn(),
|
getIDToken: vi.fn(),
|
||||||
info: vi.fn(),
|
info: vi.fn(),
|
||||||
setSecret: vi.fn()
|
setSecret: vi.fn()
|
||||||
@@ -83,6 +84,15 @@ describe('getOIDCToken', () => {
|
|||||||
expect(body.get('connection_id')).toBe(validConnectionID);
|
expect(body.get('connection_id')).toBe(validConnectionID);
|
||||||
expect(body.get('expires_in')).toBe('300');
|
expect(body.get('expires_in')).toBe('300');
|
||||||
expect(setSecretMock).toHaveBeenCalledWith('hub-token');
|
expect(setSecretMock).toHaveBeenCalledWith('hub-token');
|
||||||
|
expect(core.info).toHaveBeenCalledWith('Docker Hub OIDC detected for docker.io');
|
||||||
|
expect(core.info).toHaveBeenCalledWith('Retrieving GitHub OIDC token for Docker Hub');
|
||||||
|
expect(core.info).toHaveBeenCalledWith('Exchanging GitHub OIDC token for Docker Hub token');
|
||||||
|
expect(core.info).toHaveBeenCalledWith('Docker Hub OIDC token exchange succeeded');
|
||||||
|
expect(core.debug).toHaveBeenCalledWith('Docker Hub OIDC token audience: https://identity.docker.com');
|
||||||
|
expect(core.debug).toHaveBeenCalledWith('Docker Hub OIDC token expiration: 300s');
|
||||||
|
expect(core.debug).toHaveBeenCalledWith('Sending Docker Hub OIDC token request to https://identity.docker.com/oauth/token');
|
||||||
|
expect(core.debug).toHaveBeenCalledWith('Docker Hub OIDC token request returned status code 200');
|
||||||
|
expect(core.debug).toHaveBeenCalledWith('Docker Hub OIDC token response status code: 200');
|
||||||
});
|
});
|
||||||
|
|
||||||
test('uses custom token expiration', async () => {
|
test('uses custom token expiration', async () => {
|
||||||
|
|||||||
+33
-33
File diff suppressed because one or more lines are too long
+3
-3
File diff suppressed because one or more lines are too long
@@ -35,6 +35,10 @@ export const getOIDCToken = async (registry: string, username: string): Promise<
|
|||||||
const expiresIn = getExpiresIn();
|
const expiresIn = getExpiresIn();
|
||||||
const identityHost = registry === 'registry-1-stage.docker.io' ? 'identity-stage.docker.com' : 'identity.docker.com';
|
const identityHost = registry === 'registry-1-stage.docker.io' ? 'identity-stage.docker.com' : 'identity.docker.com';
|
||||||
const audience = `https://${identityHost}`;
|
const audience = `https://${identityHost}`;
|
||||||
|
core.info(`Docker Hub OIDC detected for ${registry || 'docker.io'}`);
|
||||||
|
core.debug(`Docker Hub OIDC token audience: ${audience}`);
|
||||||
|
core.debug(`Docker Hub OIDC token expiration: ${expiresIn}s`);
|
||||||
|
core.info(`Retrieving GitHub OIDC token for Docker Hub`);
|
||||||
const idToken = await core.getIDToken(audience);
|
const idToken = await core.getIDToken(audience);
|
||||||
const http: httpm.HttpClient = new httpm.HttpClient('github.com/docker/login-action', [], {
|
const http: httpm.HttpClient = new httpm.HttpClient('github.com/docker/login-action', [], {
|
||||||
headers: {
|
headers: {
|
||||||
@@ -49,10 +53,12 @@ export const getOIDCToken = async (registry: string, username: string): Promise<
|
|||||||
data.set('connection_id', connectionID);
|
data.set('connection_id', connectionID);
|
||||||
data.set('expires_in', expiresIn.toString());
|
data.set('expires_in', expiresIn.toString());
|
||||||
|
|
||||||
|
core.info(`Exchanging GitHub OIDC token for Docker Hub token`);
|
||||||
const resp = await postWithRetry(http, `https://${identityHost}/oauth/token`, data.toString());
|
const resp = await postWithRetry(http, `https://${identityHost}/oauth/token`, data.toString());
|
||||||
|
|
||||||
const tokenResp = <OIDCTokenResponse>JSON.parse(await handleResponse(resp));
|
const tokenResp = <OIDCTokenResponse>JSON.parse(await handleResponse(resp));
|
||||||
core.setSecret(tokenResp.access_token);
|
core.setSecret(tokenResp.access_token);
|
||||||
|
core.info(`Docker Hub OIDC token exchange succeeded`);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
username,
|
username,
|
||||||
@@ -70,16 +76,20 @@ const getExpiresIn = (): number => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
const postWithRetry = async (http: httpm.HttpClient, url: string, data: string): Promise<httpm.HttpClientResponse> => {
|
const postWithRetry = async (http: httpm.HttpClient, url: string, data: string): Promise<httpm.HttpClientResponse> => {
|
||||||
|
core.debug(`Sending Docker Hub OIDC token request to ${url}`);
|
||||||
let resp = await http.post(url, data);
|
let resp = await http.post(url, data);
|
||||||
|
core.debug(`Docker Hub OIDC token request returned status code ${resp.message.statusCode || HttpCodes.InternalServerError}`);
|
||||||
for (let attempt = 0; (resp.message.statusCode || HttpCodes.InternalServerError) === HttpCodes.TooManyRequests && attempt < maxRetries; attempt++) {
|
for (let attempt = 0; (resp.message.statusCode || HttpCodes.InternalServerError) === HttpCodes.TooManyRequests && attempt < maxRetries; attempt++) {
|
||||||
const delay = parseRetryAfter(resp.message.headers['retry-after']);
|
const delay = parseRetryAfter(resp.message.headers['retry-after']);
|
||||||
if (delay === null) {
|
if (delay === null) {
|
||||||
|
core.debug(`Docker Hub OIDC token request rate limited without retry-after header`);
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
await resp.readBody();
|
await resp.readBody();
|
||||||
core.info(`Docker Hub OIDC token request rate limited, retrying in ${delay}ms (attempt ${attempt + 1}/${maxRetries})`);
|
core.info(`Docker Hub OIDC token request rate limited, retrying in ${delay}ms (attempt ${attempt + 1}/${maxRetries})`);
|
||||||
await new Promise(resolve => setTimeout(resolve, delay));
|
await new Promise(resolve => setTimeout(resolve, delay));
|
||||||
resp = await http.post(url, data);
|
resp = await http.post(url, data);
|
||||||
|
core.debug(`Docker Hub OIDC token request returned status code ${resp.message.statusCode || HttpCodes.InternalServerError}`);
|
||||||
}
|
}
|
||||||
return resp;
|
return resp;
|
||||||
};
|
};
|
||||||
@@ -101,6 +111,7 @@ const parseRetryAfter = (value: string | string[] | undefined): number | null =>
|
|||||||
const handleResponse = async (resp: httpm.HttpClientResponse): Promise<string> => {
|
const handleResponse = async (resp: httpm.HttpClientResponse): Promise<string> => {
|
||||||
const body = await resp.readBody();
|
const body = await resp.readBody();
|
||||||
const statusCode = resp.message.statusCode || HttpCodes.InternalServerError;
|
const statusCode = resp.message.statusCode || HttpCodes.InternalServerError;
|
||||||
|
core.debug(`Docker Hub OIDC token response status code: ${statusCode}`);
|
||||||
if (statusCode < HttpCodes.OK || statusCode >= HttpCodes.MultipleChoices) {
|
if (statusCode < HttpCodes.OK || statusCode >= HttpCodes.MultipleChoices) {
|
||||||
throw parseError(statusCode, body);
|
throw parseError(statusCode, body);
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user